Fix UpdateSubChunkBlocksPacket#333
Merged
PetteriM1 merged 1 commit intoCloudburstMC:3.0from Apr 17, 2026
Merged
Conversation
PetteriM1
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateSubChunkBlocksPacket chunkX, Y, Z, are a block position, but where encoded manually and because of the BlockPos change in 944, Y was encoded wrongly (unsigned var-int instead of var-int).
See https://mojang.github.io/bedrock-protocol-docs/docs/UpdateSubChunkBlocksPacket.html
Don't know if it should be done non-breaking or be modified to shift chunkX, Y, Z accordingly